fix: task-4 review round 1 (soon-constant, computed status, id guard)

app/api/vouchers/[id]/route.ts

@@ -3,18 +3,22 @@ import { getDb } from "@/lib/db";
 
 export async function GET(_req: NextRequest, { params }: { params: Promise<{ id: string }> }) {
   const { id } = await params;
+  const numId = Number(id);
+  if (!Number.isInteger(numId)) return NextResponse.json({ error: "not found" }, { status: 404 });
   const db = getDb();
-  const v = await db.voucher.findUnique({ where: { id: Number(id) } });
+  const v = await db.voucher.findUnique({ where: { id: numId } });
   if (!v) return NextResponse.json({ error: "not found" }, { status: 404 });
   return NextResponse.json(v);
 }
 
 export async function POST(req: NextRequest, { params }: { params: Promise<{ id: string }> }) {
   const { id } = await params;
+  const numId = Number(id);
+  if (!Number.isInteger(numId)) return NextResponse.json({ error: "not found" }, { status: 404 });
   const body = await req.json().catch(() => ({}));
   if (body.action !== "redeem") return NextResponse.json({ error: "unknown action" }, { status: 400 });
   const db = getDb();
-  const v = await db.voucher.findUnique({ where: { id: Number(id) } });
+  const v = await db.voucher.findUnique({ where: { id: numId } });
   if (!v) return NextResponse.json({ error: "not found" }, { status: 404 });
   const updated = await db.voucher.update({ where: { id: v.id }, data: { status: "eingeloest", restCents: 0 } });
   return NextResponse.json(updated);

app/api/vouchers/route.ts

@@ -1,25 +1,17 @@
 import { NextRequest, NextResponse } from "next/server";
 import { getDb } from "@/lib/db";
 import { getVoucherStatus } from "@/lib/voucher-status";
-import { validateVoucher } from "@/lib/vouchers";
+import { validateVoucher, isExpiringSoon } from "@/lib/vouchers";
 
 export async function GET(req: NextRequest) {
   const filter = req.nextUrl.searchParams.get("filter");
   const db = getDb();
   const all = await db.voucher.findMany({ orderBy: { createdAt: "desc" } });
-  const now = Date.now();
-  const in14d = now + 14 * 24 * 3600 * 1000;
   const filtered = all.filter((v) => {
     const s = getVoucherStatus(v);
     if (filter === "eingeloest") return s === "eingeloest";
     if (filter === "abgelaufen") return s === "abgelaufen";
-    if (filter === "bald")
-      return (
-        s === "aktiv" &&
-        v.ablaufdatum &&
-        new Date(v.ablaufdatum).getTime() >= now &&
-        new Date(v.ablaufdatum).getTime() <= in14d
-      );
+    if (filter === "bald") return s === "aktiv" && isExpiringSoon(v.ablaufdatum);
     if (filter === "aktiv") return s === "aktiv";
     return true;
   });